What am I doing wrong here?

This feature is not available yet nor in your version nor in current openzfs version.

https://github.com/openzfs/zfs/blob/master/man/man8/zpool-attach.8#L48

You can't extend the existing raidz1 vdev by adding another disk but you can add another vdev to the pool to increase the pool's capacity. You'll need more than one additional disk if you want to retain redundancy. For example, you could use two disks to add a mirror vdev or 3+ disks for another raidz1 vdev.

TLDR: You cannot add devices to a RAIDZ… yet (edited bellow) !

This is an old limitation as mentioned by Dan Naumov in 2009

To reiterate, you cant just add a single disk drive to a raidz1 or raidz2 pool. This is a known limitation (you can check with SUN ZFS docs). If you have an existing raidz and you MUST increase that particular pool's storage capabilities, you have 3 options:

1. Add a raidz of the same configuration to the pool (think 3 disk raidz + 3 disk raidz or 5 + 5, for example)
2. Replace each (and every) disk in your raidz pool one by one, letting it resilver after inserting each upgraded disk
3. Backup your data, destroy your pool and create a new raidz pool with a bigger amount of disks.

But current docs still mention it:

zpool attach [-f] [-o property=value] pool device new_device

Attaches new_device to an existing zpool device. The existing device cannot be part of a raidz configuration. If device is not currently part of a mirrored configuration, device automatically transforms into a two-way mirror of device and new_device. If device is part of a two-way mirror, attaching new_device creates a three-way mirror, and so on. In either case, new_device begins to resilver immediately.

November 2023 edit : Hey Marty, we received news from the future!

RAIDZ extension is announced to be released in ZFS 2.3. It was a long run issue (~6 years), details in OpenZFS Developer Summit 2023 :

• the talk
• the slides

You can't expand an existing raidz vdev, you have to blow it away and create it again with the new drive(s). See the other answer for better details.

Side note: Someone actually worked out that it's technically possibly to add drives to a raidz, but the functionality hasn't been implemented. The same is true of removing a disk.

You have various options. I'm assuming here that you have the 4 disks arranged as a raidz1 (like raid5) layout. Not ideal, but I won't go into discussions about the best disk layout.

1. You can go and buy big 4/5/8/XTB disks in a few years and just replace the disks one by one. When they have all been replaced the size of the pool should increase.
2. You can add a second group of 4 disks to the original pool. (Adding a new vdev in ZFS terms). The new vdev should ideally be the same type as the first, so if you first 4 disks are set as raidz1, the next four should be as well.
3. You can make a new, independent pool out of the new disks.